Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output view error when notebook closed #7301

Closed
wallneradam opened this issue Oct 8, 2019 · 0 comments · Fixed by #7633
Closed

Output view error when notebook closed #7301

wallneradam opened this issue Oct 8, 2019 · 0 comments · Fixed by #7633
Labels
bug pkg:notebook status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.

Comments

@wallneradam
Copy link

wallneradam commented Oct 8, 2019

Description

When I close notebook while output view is opened, I have an error in JS console of the browser, and output view is not closed automaticallly.

It also throws error on notebook close, when I manually close the output window before closing notebook.

Reproduce

  1. Open a notebook.
  2. Run a cell, to produce an output
  3. Right click on the output and select "Create new view for output"
  4. Close the notebook
  5. See the error in the javascript console

Expected behavior

As I see in the souce code, Output view should be closed (without the error) when the notebook is closed.

Context

I disabled all the extensions, the problem still occurs.

  • Operating System and version: Ubuntu 19.04
  • Browser and version: Chromium 76.0.3809.100
  • JupyterLab version: 1.1.4
Troubleshoot Output
Not relevant, it is client side issue.
Command Line Output
Not relevant, it is client side issue.
Browser Output
index.js:220 TypeError: Cannot read property 'cells' of null
    at index.js:1343
    at invokeSlot (index.js:475)
    at Object.emit (index.js:433)
    at Signal.push.qUp9.Signal.emit (index.js:106)
    at Notebook.push.FmDU.Widget.dispose (widget.js:66)
    at Notebook.dispose (widget.js:210)
    at Notebook.dispose (widget.js:718)
    at NotebookPanel.dispose (panel.js:98)
    at widgetmanager.js:256
@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Jan 16, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug pkg:notebook status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants