Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closing a notebook during a cell execute throws an error #7554

Closed
jtpio opened this issue Nov 22, 2019 · 0 comments · Fixed by #7555
Closed

Closing a notebook during a cell execute throws an error #7554

jtpio opened this issue Nov 22, 2019 · 0 comments · Fixed by #7555
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Milestone
2.0

Comments

@jtpio
Copy link
Member

jtpio commented Nov 22, 2019

Closing a notebook widget while a cell is being executed throws an error in the dev tools console:

Uncaught (in promise) TypeError: Cannot read property 'future' of null
    at Function.t [as execute] (widget.js:841)

For example with the following code:

import time
time.sleep(10)

kernel-future-disposed-widget

It doesn't seem to be really harmful, but still nice to track somewhere.

Might be fixed by #7252?
jasongrout added a commit to jasongrout/jupyterlab that referenced this issue Nov 22, 2019
@jasongrout
Handle cell execution cancellation because the notebook is being disp…
c8ca46c 
…osed

Fixes jupyterlab#7554
jasongrout added a commit to jasongrout/jupyterlab that referenced this issue Nov 22, 2019
@jasongrout
Handle cell execution cancellation because cell is disposed.
970fba0 
Fixes jupyterlab#7554
@jasongrout jasongrout mentioned this issue Nov 22, 2019
Merged
@jasongrout jasongrout added this to the 2.0 milestone Nov 22, 2019
@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Dec 22, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Dec 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Milestone
2.0
Development

Successfully merging a pull request may close this issue.

Handle cell execution cancellation because cell is disposed. jasongrout/jupyterlab
2 participants
@jasongrout @jtpio