Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instructions for shorcut editor is out of date #7570

Open
plynch-chwy opened this issue Nov 29, 2019 · 1 comment
Open

Instructions for shorcut editor is out of date #7570

plynch-chwy opened this issue Nov 29, 2019 · 1 comment
Labels
tag:Keyboard Compatibility issues with keyboards, including locale-specific and layout-specific issues

Comments

@plynch-chwy
Copy link

plynch-chwy commented Nov 29, 2019

The instructions for editing user shortcuts seem to be out of date (Version 1.2.3).

In the system defaults shortcuts, there is an example comment for how to disable a keyboard shortcut:

    // Note: To disable a system default shortcut,
    // copy it to User Preferences and add the
    // "disabled" key, for example:
    // {
    //     "command": "application:activate-next-tab",
    //     "keys": [
    //         "Ctrl Shift ]"
    //     ],
    //     "selector": "body",
    //     "disabled": true
    // }

The stable docs also has a short video on how to change a keyboard shortcut:
https://jupyterlab.readthedocs.io/en/stable/user/interface.html#keyboard-shortcuts
https://www.youtube.com/watch?v=rhW3kAExCik

These instructions seem to be out of date and don't match current json structure of system defaults.

For me to add a shortcut I had to use this structure (which isn't immediately obvious since the User Preferences starts as {}):

{
    "shortcuts": [
        {
            "command": "apputils:activate-command-palette",
            "keys": [
                "Accel Shift P"
            ],
            "selector": "body"
        }
    ]
}

May be more helpful to set the default User Preferences to something that makes it easier for new users to copy and paste the current shortcuts into their preferences like below:

{
    "shortcuts": [
    ]
}
@groutr
Copy link
Contributor

groutr commented Dec 6, 2019

I also ran into this working on #7589. @plynch-chwy, that is a good suggestion, however, #7597 would remove the need to edit a settings file altogether. You're right, though, the documentation is out of date.

@JasonWeill JasonWeill added the tag:Keyboard Compatibility issues with keyboards, including locale-specific and layout-specific issues label Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag:Keyboard Compatibility issues with keyboards, including locale-specific and layout-specific issues
Projects
None yet
Development

No branches or pull requests

3 participants