Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add arg to 'help:open' command to force using new browser tab #7602

Closed
fcollonval opened this issue Dec 7, 2019 · 0 comments · Fixed by #7603
Closed

Add arg to 'help:open' command to force using new browser tab #7602

fcollonval opened this issue Dec 7, 2019 · 0 comments · Fixed by #7603
Assignees
@fcollonval
Labels
enhancement pkg:help status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.

Comments

@fcollonval
Copy link
Member

In @jupyterlab/git, we have to define a new command to force opening help websites in new browser tab (because the websites were not supporting iframe):

https://github.com/jupyterlab/jupyterlab-git/blob/master/src/gitMenuCommands.ts#L98-L104

I propose to add an argument in 'help:open' to cover that behaviour.
@fcollonval fcollonval self-assigned this Dec 7, 2019
@fcollonval fcollonval mentioned this issue Dec 7, 2019
Merged
@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Jan 8, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@fcollonval fcollonval

Labels
enhancement pkg:help status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Optionnaly force new browser tab fcollonval/jupyterlab
1 participant
@fcollonval