New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split off some parts of coreutils #7615
Comments
One issue would also be to consider what this means:
And figure out which if any new packages should be marked similarly. |
Based on the in-person discussions today, I think we should make the following new packages:
The first two to aid in discoverability since they are token providers, and the last because its API is most likely to evolve over time. I think this strikes a good balance between package number and scope explosion. |
If
|
If we're going to make a new package for nbformat, can we make the name such that moving other validation and message functions from services works too? For example, |
To clarify for readers not in our previous call: @jasongrout is thinking to move some of the code that is part of the service refactor (validation and typings of server API messages) to a separate package for reuse by others. The suggestion seems to be that these live in the same package as nbformat. I think the rationale is that there would be overlap between the contributors to those two parts. Personally, I'm unsure if there would be significant overlap between the users of those two parts. |
In concert with the major version release of coreutils, we should consider splitting off some parts of the package into new ones.
Pros:
X || Y
semver dependency).polling
out (to Lumino, see Port coreutils#Poll to Lumino #7598) so now is probably the best time to move other parts as well.Cons:
What to split off
The current exported symbols of coreutils are:
For me the clearest candidates for being split off are the things that export Tokens, namely StateDB and the SettingsRegistry. These are larger components, that would benefit from being semvered independently.
Other candidates:
moment.js
is a big dependency for what is marketed as a "util". See discussions in e.g. switch from moment.js to date-fns #7137I would very much like some input on which parts people think makes sense to split off, and which parts to keep in coreutils. We would also need to decide how to redistribute any such parts (move to other packages, make a new package per component, make a new package for some of the components). Note that this is also somewhat time critical to get in before we try to freeze the API for 2.0.
The text was updated successfully, but these errors were encountered: