Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow the client session dialogs to be customized #7616

Closed
blink1073 opened this issue Dec 11, 2019 · 0 comments · Fixed by #7618
Closed

Allow the client session dialogs to be customized #7616

blink1073 opened this issue Dec 11, 2019 · 0 comments · Fixed by #7618
Assignees
@blink1073
Labels
pkg:apputils status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Milestone
2.0

Comments

@blink1073
Copy link
Member

Description

ClientSession currently has two pieces of UI (restart and selectKernel) baked in. The selectKernel dialog is used by statusbar, notebook, and console extensions. The restart UI is used by all of the above and fileeditor. Note that the ClientSession objects themselves are currently created by the DocumentManager (and in turn within Context), and also by the ConsolePanel.
I propose that we have a separate ISessionContextDialogs provider that is used by these four extensions to handle the UI. Note that ClientSession is being renamed to SessionContext in #4724.
@blink1073 blink1073 added this to the 2.0 milestone Dec 11, 2019
@blink1073 blink1073 self-assigned this Dec 11, 2019
This was referenced Dec 11, 2019
Merged
Merged
@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Jan 24, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@blink1073 blink1073

Labels
pkg:apputils status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Milestone
2.0
Development

Successfully merging a pull request may close this issue.

Make session dialogs configurable blink1073/jupyterlab
1 participant
@blink1073