Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump celltags to 1.0.0 #7629

Closed
jasongrout opened this issue Dec 14, 2019 · 3 comments · Fixed by #7636
Closed

bump celltags to 1.0.0 #7629

jasongrout opened this issue Dec 14, 2019 · 3 comments · Fixed by #7636
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Milestone

Comments

@jasongrout
Copy link
Contributor

Cell tags was merged into core in #7407. We decided around the 1.0 release that anything in core should be at least 1.0.0 so that we could release patch versions of those libraries with patch versions of jlab. Hence, I think we should bump the version of celltags to at least 1.0.0.

@jasongrout jasongrout added this to the 2.0 milestone Dec 14, 2019
@telamonian
Copy link
Member

Would it make sense to bump celltags straight to 2.0.0? The more in lockstep all of the package versions are, the easier it is to get the versions right when defining dependencies in a package.json. For example, when writing an extension that targets a particular version of jlab core, I often find it pretty confusing to remember the special versioning rules for @jupyterlab/coreutils and @jupyterlab/services.

@jasongrout
Copy link
Contributor Author

jasongrout commented Dec 14, 2019

I'm okay with either one. Note that the minor versions are already off in general, and certainly patch numbers can be off.

@telamonian
Copy link
Member

I'll put a PR for this on my todo list

@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Jan 16, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants