Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not change currentWidget for console properly #7648

Closed
KsavinN opened this issue Dec 18, 2019 · 5 comments · Fixed by #7705
Closed

Not change currentWidget for console properly #7648

KsavinN opened this issue Dec 18, 2019 · 5 comments · Fixed by #7705
Assignees
@KsavinN
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.

Comments

@KsavinN
Copy link
Contributor

KsavinN commented Dec 18, 2019

Description

during create another console and switch back current widget it still points to the new console, not focused.

Reproduce

consoleIssue
@jasongrout
Copy link
Contributor

Perhaps this is related to #7641?

@jasongrout
Copy link
Contributor

I also wonder if perhaps this might be fixed by #7645 - wrapping the console in a main area widget takes care of some standardized focusing behaviors.

@jasongrout
Copy link
Contributor

Your screenshot is cut off so we can't see the indicator on the tab. Is the blue line indicator on the tab switching appropriately?

@KsavinN
Copy link
Contributor Author

KsavinN commented Dec 18, 2019 •
edited by afshin

anotherGif

As you @jasongrout mention its related with #7645. Could you or someone else assign me to this issue, cause I don't have privileges. And I hope that I will try to fix that as fast as I can :)

@jasongrout
Copy link
Contributor

Thanks for working on this!

@KsavinN KsavinN mentioned this issue Dec 27, 2019
Merged
@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Feb 2, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Feb 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@KsavinN KsavinN

Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change Tracker from MainAreaWidget back to ConsolePanel KsavinN/jupyterlab
2 participants
@jasongrout @KsavinN