Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade node and revert ensure-max-old-space #7675

Closed
jasongrout opened this issue Dec 21, 2019 · 0 comments · Fixed by #7677
Closed

Upgrade node and revert ensure-max-old-space #7675

jasongrout opened this issue Dec 21, 2019 · 0 comments · Fixed by #7677
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Milestone
2.0

Comments

@jasongrout
Copy link
Contributor

As discussed in #7175, node 12 is now LTS, so we can move to it and revert #7201
@jasongrout jasongrout added this to the 2.0 milestone Dec 21, 2019
jasongrout added a commit to jasongrout/jupyterlab that referenced this issue Dec 21, 2019
@jasongrout
Revert ensure-max-old-space now that node 12+ has better default memo…
f070ef7 
…ry ceilings.

This reverts jupyterlab#7201 as discussed in jupyterlab#7175

Fixes jupyterlab#7675
@jasongrout jasongrout mentioned this issue Dec 21, 2019
Merged
@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Jan 24, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Milestone
2.0
1 participant
@jasongrout