Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert icons backwards compatibility workarounds #7685

Closed
jasongrout opened this issue Dec 23, 2019 · 6 comments
Closed

Revert icons backwards compatibility workarounds #7685

jasongrout opened this issue Dec 23, 2019 · 6 comments
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Milestone
2.0

Comments

@jasongrout
Copy link
Contributor

Looks like some of the backwards compatibility workarounds in #7182 can be reverted now master is on 2.0.

CC @telamonian
@jasongrout
Copy link
Contributor Author

In particular, see the notes in https://github.com/jupyterlab/jupyterlab/pull/7182/files#diff-8c86f33bb6f77c0c318375327e2472fe

@jasongrout jasongrout added this to the 2.0 milestone Dec 23, 2019
@telamonian
Copy link
Member

I'm handling this as part of #7299

@jasongrout
Copy link
Contributor Author

Is #7299 making it into the beta? We were hoping to freeze the api.

CC @blink1073

@telamonian
Copy link
Member

telamonian commented Dec 23, 2019 •
edited

I'm working on #7299 and the somewhat related #7574 right now. I would like to get them into 2.0, but I'll probably need at least one more day

@jasongrout
Copy link
Contributor Author

Fixed by #7700, right?

@telamonian
Copy link
Member

fixed by #7700

@telamonian telamonian mentioned this issue Jan 14, 2020
Merged
@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Feb 6, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Feb 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
2 participants
@jasongrout @telamonian