Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Advanced Settings does not trigger application dirty state #7757

Closed
jasongrout opened this issue Jan 8, 2020 · 1 comment · Fixed by #7774
Closed

Advanced Settings does not trigger application dirty state #7757

jasongrout opened this issue Jan 8, 2020 · 1 comment · Fixed by #7774
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:Settings

Comments

@jasongrout
Copy link
Contributor

jasongrout commented Jan 8, 2020 •
edited

If you are editing settings, then accidentally refresh, the application refreshes without prompting you to save the setting text. Instead, we should have the advanced setting editor trigger the application dirty status when it has unsaved content.
@Madhu94
Copy link
Contributor

Madhu94 commented Jan 11, 2020

I'll take a look at this.

Madhu94 added a commit to Madhu94/jupyterlab that referenced this issue Jan 12, 2020
@Madhu94
Changes to setting editor should trigger application
3114c2e 
dirty state

Fixes jupyterlab#7757
@Madhu94 Madhu94 mentioned this issue Jan 12, 2020
Merged
@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Feb 12, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Feb 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:Settings
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Changes to setting editor should trigger application dirty state Madhu94/jupyterlab
2 participants
@jasongrout @Madhu94