Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for html refresh does not work (for reveal js only?) #7552 #7823

Closed
ggbhat opened this issue Jan 25, 2020 · 0 comments
Closed

Fix for html refresh does not work (for reveal js only?) #7552 #7823

ggbhat opened this issue Jan 25, 2020 · 0 comments
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.

Comments

@ggbhat
Copy link
Contributor

ggbhat commented Jan 25, 2020

References
Fix for #7552

Code changes
As @jasongrout suggested added dirty check and reload from disk instead of just reassigning the content url for iframe in htmlviewer.
Also added dirty check for reload from disk logic so that confirmation dialog will be shown only if the current context model is dirty.

User-facing changes
None.
@ggbhat ggbhat closed this as completed Jan 25, 2020
@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Feb 24, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Feb 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ggbhat