Some icons look "dimmer" with the Dark Theme in 2.0

[jtpio]

Testing from the current master, some icons (mostly the check marks and submenu arrows) now look dimmer than before (1.x).

With 1.2.6:

With 2.0 / current master:

[jasongrout]

Testing, this seemed to change between 2.0b1 and 2.0b2. It seems that the icon pulled in by the css has a different svg font color between then. @telamonian - do you know of an easy workaround to have brighter checkmarks? Is this related to (IIRC) consolidating the svgs for various themes into the ui package, so you only get one svg?

It looks like the checkmark is currently using this css:

jupyterlab/packages/apputils/style/commandpalette.css

Lines 166 to 170 in f17361c

	.lm-CommandPalette-item.lm-mod-toggled .lm-CommandPalette-itemIcon {
	background-image: var(--jp-icon-check);
	background-size: 16px;
	background-repeat: no-repeat;
	}

[telamonian]

No, sadly there's no workaround that is both clean and easy. The real problem is that there's no underlying support in lumino for LabIcon-like icons in commands or menu items (as there currently is in lumino title objects, via their .iconRenderer prop). I'm working on fixing that right now.

I really wanted to avoid it, but the quick and dirty fix would be to just go back to having 2 of each of the icons (light/dark) that get used in the menus. The drawback (aside from being an annoying mess for me to maintain, especially on a temporary basis) is that the icon colors wouldn't match to any custom theme, just to the default light/dark themes. I'd prefer if we lived with the styling defect for a week or two, I'll go and fix the underlying issue in lumino, and then we can fix the menu icon styling for real in a 2.0.x point release

[telamonian]

This will get fixed by #7864