Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3 checkpoint get requests invoked to load a single notebook #7889

Closed
ikiw opened this issue Feb 17, 2020 · 0 comments · Fixed by #7926
Closed

3 checkpoint get requests invoked to load a single notebook #7889

ikiw opened this issue Feb 17, 2020 · 0 comments · Fixed by #7926
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.

Comments

@ikiw
Copy link
Contributor

ikiw commented Feb 17, 2020 •
edited

Description

3 checkpoint get requests are invoked to load a single notebook. While this doesn't have any effect while running the jupyterlab in local, but the slowness is quite visible in a hosted notebook environment with the subsequent requests taking more time in the waiting state.

Reproduce

  1. Go to Jupyterlab
  2. Click on any notebook
  3. Check the network log for checkpoint requests

Expected behavior

Should avoid the redundant requests. 1 checkpoint call per notebook.

Context

  • Operating System and version: mac OS
  • Browser and version: Chrome V80
  • JupyterLab version: master
Troubleshoot Output 
Paste the output from running `jupyter troubleshoot` from the command line here.
You may want to sanitize the paths in the output.
Command Line Output 
Paste the output from your command line running `jupyter lab` here, use `--debug` if possible.
Browser Output 
Screenshot 2020-02-17 at 4 58 35 PM
ikiw pushed a commit to ikiw/jupyterlab that referenced this issue Feb 18, 2020
1.Resolve jupyterlab#7889 to fetch only 1 checkpoint call per noteboo…
3cc7de2 
…k. 2.Refactor PR 7879 to use debouncer
@ikiw ikiw mentioned this issue Feb 18, 2020
Closed
ikiw added a commit to ikiw/jupyterlab that referenced this issue Feb 25, 2020
@ikiw
Resolve jupyterlab#7889 to fetch only 1 checkpoint call per notebook
2473e17
@ikiw ikiw mentioned this issue Feb 25, 2020
Merged
blink1073 pushed a commit that referenced this issue Mar 7, 2020
Merge pull request #7926 from ikiw/checkpoint-calls
aa3f0a0 
Resolve #7889 to avoid redundant checkpoint calls on loading notebook
@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Apr 15, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Milestone
No milestone
1 participant
@ikiw