Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeMirror font size setting issue (#7909) #7910

Merged
merged 1 commit into from Feb 24, 2020

Conversation

AlbertHilb
Copy link
Contributor

Use the right property name, font-size, in the style declaration.

Fixes #7909.

Regards

@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

Copy link
Member

@telamonian telamonian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I tested this out locally and the fix works

@telamonian telamonian merged commit ec932f8 into jupyterlab:master Feb 24, 2020
@telamonian telamonian added this to the 2.0 milestone Feb 24, 2020
@AlbertHilb AlbertHilb deleted the FontSizeIssue branch February 24, 2020 18:37
@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Mar 27, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug pkg:codemirror status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CodeMirror file editor does not respect font size Settings value
2 participants