Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run test-services first in Linux/Windows JS CI tests #7918

Closed
telamonian opened this issue Feb 24, 2020 · 1 comment
Closed

Run test-services first in Linux/Windows JS CI tests #7918

telamonian opened this issue Feb 24, 2020 · 1 comment
Milestone

Comments

@telamonian
Copy link
Member

While working on #7864 over the weekend, the Linux/Windows JS CI tests each had at least half a dozen spurious failures. Every single time the failure occurred during the run of the test-services package. The test-whatever packages are run in alphabetical order, so test-services isn't run until near the end of the tests, at around the ~30-35 min mark.

I think it would make the CI slightly less painful to deal with if test-services ran first. The tests would still fail the same, of course, but at least that way we wouldn't have to wait 30 minutes just to see the test die. Is this a sensible proposal?

@jtpio
Copy link
Member

jtpio commented Dec 14, 2021

Closing as js-services are now run separately, and are also grouped in a "Flaky" workflow so it's easier to restart them independently without restarting all the others: https://github.com/jupyterlab/jupyterlab/blob/master/.github/workflows/linuxjs-flaky-tests.yml

Thanks!

@jtpio jtpio closed this as completed Dec 14, 2021
@jtpio jtpio added this to the Reference milestone Dec 14, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants