Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Where did execution timings go? (Jupyterlab 2.0) #8054

Closed
aquirdTurtle opened this issue Mar 19, 2020 · 5 comments
Closed

Where did execution timings go? (Jupyterlab 2.0) #8054

aquirdTurtle opened this issue Mar 19, 2020 · 5 comments
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Milestone

Comments

@aquirdTurtle
Copy link

Hello, I noticed a while ago when this PR was merged. In jupyterlab version 1.2.6 I can make use of this. But now, in Jupyterlab 2.0, I no longer see the Toggle Recording Cell Timing command, and adding the "record_timing": true metadata to the notebook metadata manually doesn't seem to work either. Where did it go? I was just about to implement an extension like the old notebook extension using this.

@jasongrout
Copy link
Contributor

Look in the Advanced Settings for notebooks - we made it a system-wide setting, rather than a setting in specific notebooks. See the changelog at https://jupyterlab.readthedocs.io/en/stable/getting_started/changelog.html#v2-0-0, in particular:

Notebook recordTiming advanced setting to control whether execution timing information is stored in notebook files (#7578)

@jasongrout jasongrout added this to the Reference milestone Mar 19, 2020
@aquirdTurtle
Copy link
Author

Great, thanks.

@mlucool
Copy link
Contributor

mlucool commented Mar 19, 2020

@aquirdTurtle I actually already wrote a plugin that does this. Let me see if I can get it in shape to share. Would you mind holding off a week or so?

@aquirdTurtle
Copy link
Author

@mlucool Ah, this type of thing seems to happen all the time with jupyterlab extensions. Unfortunately I've already put in a good chunk of work - if it weren't for this issue I ran into in Jupyterlab 2.0 I'd have an early version already ready to publish. But quite possibly your version would be far superior - I'm a very inexperienced with javascript and these things. I think it makes sense for - once this issue gets resolved - to go ahead and publish my work so far, but if your plugin is superior I'm happy to defer to that once it's out. Does that sound good?

@mlucool
Copy link
Contributor

mlucool commented Apr 7, 2020

@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label May 20, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

No branches or pull requests

3 participants