string color hard to see color in dark theme

[blaylockbk]

I love the dark theme, but the dark red string color is very difficult to see against the dark background (I have been accused of color blindness)

jupyterlab/packages/theme-dark-extension/style/variables.css

Line 352 in 083c65d

--jp-mirror-editor-string-color: #ba2121;

Can it be changed to have a higher contrast ratio against the black background

from #ba2121

to #ff7070

---

I changed this in my personal environment, but thought it might be helpful for other people using Jupyter's Dark Theme.

Before...

After...

[jasongrout]

CC @tgeorgeux

[jasongrout]

See also #7779, which advocates for much larger changes. I agree the red is hard to read - perhaps just this could be changed with much less controversy?

[jasongrout]

I changed this in my personal environment,

Just curious, how did you change this?

[blaylockbk]

I changed the line in the file

~/anaconda3/envs/best/share/jupyter/lab/themes/@jupyterlab/theme-dark-extension/index.css

[jasongrout]

Thanks. I was wondering if you had used an "official" way to change the color (like making your own theme), or if you just hacked it in.

[tgeorgeux]

That change looks great to me. I ran it through webAims contrast checker to be sure and it passes with flying colors!

[jasongrout]

@tgeorgeux - how about you make the final call on if this is the shade of red we want, and merge it if it's good, or if you want to tweak it more.

[tgeorgeux]

I think this color is better than what we're currently using, the changes in #7779 are larger and need more consideration, but for 2.1 this is a good change that we should implement. I can make a PR to try to get this in before Monday.

[blaylockbk]

Thanks for making the change! I think a lot of people will appreciate it.