-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NotebookModel
memory leak
#8371
Comments
Just checking: by closing this issue, are you saying that the notebook models actually are garbage collected after all? |
No, unfortunateIy not. |
Thanks for investigating! |
Does the memory leak still occur if you have multiple tabs open when you close the notebook tab? I did notice a potential memory leak issue a while back where some Lumino cleanup code doesn't get called on the closed TabBar item if it's the last one in the TabBar. At the time, I didn't investigate it further to see if it was causing any more pervasive issues |
@telamonian Yes, it is still present.
Most of the retainers seem signaling related. |
IIRC, this line should disconnect this signal connection |
On disposal, IIRC, |
I know, but, maybe, it doesn't. I will take a look tomorrow. |
I confirm, the signal mentioned above is one of the causes of the memory leak. This is what happens. When the signal connection is set, an That However, as I said, this is only one of ten |
Another cause of the When a new The
So it contains a reference to |
NotebookModel
is not deleted after a notebook tab is closed.Reproduce
NotebookModel
s are present.Expected behavior
I don't master jupyterlab internal design, but I think no
NotebookModel
should be in memory or, at most, only one.Context
The text was updated successfully, but these errors were encountered: