New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies for 3.0 #9297
Comments
Yep, I've noticed that too, especially in the browser console, where it complains that react is the wrong version. |
blueprintjs have just added React 17 as peer dependency: palantir/blueprint#4403 Xref #9227 (comment) |
Nice, thanks @fcollonval for the heads-up! |
For |
We decided in the dev meeting that these warnings are fine in 3.0 (given that react 17 is very backwards compatible), and they will get better over time as the community migrates. We might recant this if there are user-visible warnings in the js console. |
JupyterLab 3.0rc10 does not have these sorts of warnings for me in the browser js console. |
Updated the title to " Update dependencies for 3.0". We should be able to close this issue, since updating Unless we want to update a couple more, for example the eslint dev dependencies. |
Here is a list of the current warnings for me when doing I've checked them off if I think there is nothing more to do for 3.0 to update them.
|
If someone can takeover looking at each of these and either deciding they are not important for 3.0, or if we should do something about them, and updating the comment above, that would help us keep track of what we are doing for 3.0 and what we are leaving on the table for later. |
Comment: following #9227, it would be good to update to @types/react v17 that was release a week ago (https://www.npmjs.com/package/@types/react/v/17.0.0). This can be confusing if not updated due to the explicit dependency in @jupyterlab/apputils. |
Sounds good, thanks @fcollonval. I was wondering why |
Ja this is still weird for me. Thanks for pointing to the related PR. It may be that with typescript being more mature now the situation is improved and the types could be moved to dev dependencies. But this definitely will require testing. |
Yes probably something to reconsider post 3.0. It indeed looks like they could eventually be moved back to |
Closing as addressed for this release |
There seems to be a couple of dependency warnings when building extensions with the latest rc7 packages:
Most seem to be related to the recent update to React 17: #9227
The text was updated successfully, but these errors were encountered: