Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies for 3.0 #9297

Closed
jtpio opened this issue Nov 6, 2020 · 15 comments
Closed

Update dependencies for 3.0 #9297

jtpio opened this issue Nov 6, 2020 · 15 comments
Assignees
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Milestone

Comments

@jtpio
Copy link
Member

jtpio commented Nov 6, 2020

There seems to be a couple of dependency warnings when building extensions with the latest rc7 packages:

warning @jupyterlab/application > @jupyterlab/ui-components > @blueprintjs/core > popper.js@1.16.1: You can find the new Popper v2 at @popperjs/core, this package is dedicated to the legacy v1
warning @jupyterlab/application > @jupyterlab/ui-components > @blueprintjs/core > react-popper > popper.js@1.16.1: You can find the new Popper v2 at @popperjs/core, this package is dedicated to the legacy v1
warning @jupyterlab/builder > @jupyterlab/buildutils > crypto@1.0.1: This package is no longer supported. It's now a built-in Node module. If you've depended on crypto, you should switch to the one that's built-in.
[2/4] Fetching packages...
[3/4] Linking dependencies...
warning " > @lumino/coreutils@1.5.3" has unmet peer dependency "crypto@1.0.1".
warning "@jupyterlab/application > @jupyterlab/ui-components > @blueprintjs/select@3.14.3" has incorrect peer dependency "react@^15.3.0 || 16".
warning "@jupyterlab/application > @jupyterlab/ui-components > @blueprintjs/select@3.14.3" has incorrect peer dependency "react-dom@^15.3.0 || 16".
warning "@jupyterlab/application > @jupyterlab/ui-components > @blueprintjs/core > react-popper@1.3.7" has incorrect peer dependency "react@0.14.x || ^15.0.0 || ^16.0.0".
warning "@jupyterlab/application > @jupyterlab/ui-components > @blueprintjs/core > react-popper > create-react-context@0.3.0" has incorrect peer de

Most seem to be related to the recent update to React 17: #9227

@jtpio jtpio added this to the 3.0 milestone Nov 6, 2020
@jasongrout
Copy link
Contributor

Yep, I've noticed that too, especially in the browser console, where it complains that react is the wrong version.

@fcollonval
Copy link
Member

blueprintjs have just added React 17 as peer dependency: palantir/blueprint#4403

Xref #9227 (comment)

@jtpio
Copy link
Member Author

jtpio commented Nov 11, 2020

Nice, thanks @fcollonval for the heads-up!

@jtpio
Copy link
Member Author

jtpio commented Nov 11, 2020

For css-loader, it looks like we are 2 major versions behind. And upgrading would involve some updates to address the breaking changes: #8921 (comment)

@jtpio
Copy link
Member Author

jtpio commented Nov 12, 2020

Yep, I've noticed that too, especially in the browser console, where it complains that react is the wrong version.

Some of the warnings are now gone in rc8:

image

@jasongrout
Copy link
Contributor

We decided in the dev meeting that these warnings are fine in 3.0 (given that react 17 is very backwards compatible), and they will get better over time as the community migrates. We might recant this if there are user-visible warnings in the js console.

@jasongrout
Copy link
Contributor

We might recant this if there are user-visible warnings in the js console.

JupyterLab 3.0rc10 does not have these sorts of warnings for me in the browser js console.

@jtpio jtpio changed the title Update dependencies Update dependencies for 3.0 Nov 20, 2020
@jtpio
Copy link
Member Author

jtpio commented Nov 20, 2020

Updated the title to " Update dependencies for 3.0".

We should be able to close this issue, since updating css-loader can be addressed later:

#9364 (comment)

Unless we want to update a couple more, for example the eslint dev dependencies.

@jasongrout
Copy link
Contributor

jasongrout commented Nov 20, 2020

Here is a list of the current warnings for me when doing pip install -ve .

I've checked them off if I think there is nothing more to do for 3.0 to update them.

  • tsutil not updated yet. More info at Bump the ESLint dev dependencies #9391

    warning "@typescript-eslint/eslint-plugin > tsutils@3.17.1" has unmet peer dependency "typescript@>=2.8.0 || >= 3.2.0-dev || >= 3.3.0-dev || >= 3.4.0-dev || >= 3.5.0-dev || >= 3.6.0-dev || >= 3.6.0-beta || >= 3.7.0-dev || >= 3.7.0-beta".

  • Spurious warning?

    warning " > react-docgen-typescript-loader@3.7.2" has unmet peer dependency "typescript@*".

  • Removed

    warning "react-docgen-typescript-loader > @webpack-contrib/schema-utils@1.0.0-beta.0" has unmet peer dependency "webpack@^3.0.0 || ^4.0.0".

  • Spurious warning?

    warning "react-docgen-typescript-loader > react-docgen-typescript@1.20.3" has unmet peer dependency "typescript@>= 3.x".

  • Spurious warning?

    warning " > typedoc@0.17.0-3" has unmet peer dependency "typescript@>=3.7".

  • Spurious warning?

    warning " > @jupyterlab/ui-components@3.0.0-rc.10" has unmet peer dependency "react@^17.0.1".

  • Discussed at Update css-loader, style-loader and mini-css-extract-plugin #9364, fixed in Make css dependency graph of js modules #9407

    warning "workspace-aggregator-8cdbb08c-5596-4d6c-b0cd-64b3ff91330b > @jupyterlab/application-top > css-loader@3.2.1" has incorrect peer dependency "webpack@^4.0.0".

  • TODO: update style-loader and mini-css-extract-plugin. See Update css-loader, style-loader and mini-css-extract-plugin #9364 for more info. Fixed by Update style-loader and mini-css-extract-plugin #9451

  • Spurious warning?

    warning "workspace-aggregator-8cdbb08c-5596-4d6c-b0cd-64b3ff91330b > @jupyterlab/example-federated-middle > @lumino/coreutils@1.5.3" has unmet peer dependency "crypto@1.0.1".

  • react-paginate is not updated yet

    warning "workspace-aggregator-8cdbb08c-5596-4d6c-b0cd-64b3ff91330b > @jupyterlab/extensionmanager > react-paginate@6.3.2" has incorrect peer dependency "react@^16.0.0".

  • react-highlighter is not updated yet, confirmed that highlighting still works

    warning "workspace-aggregator-8cdbb08c-5596-4d6c-b0cd-64b3ff91330b > @jupyterlab/json-extension > react-highlighter@0.4.3" has incorrect peer dependency "react@^0.14.0 || ^15.0.0 || ^16.0.0".

  • react-json-tree is not updated yet

    warning "workspace-aggregator-8cdbb08c-5596-4d6c-b0cd-64b3ff91330b > @jupyterlab/json-extension > react-json-tree@0.12.1" has incorrect peer dependency "react@^16.3.0".

  • react-json-tree is not updated yet

    warning "workspace-aggregator-8cdbb08c-5596-4d6c-b0cd-64b3ff91330b > @jupyterlab/json-extension > react-json-tree@0.12.1" has incorrect peer dependency "react-dom@^16.3.0".

  • Removed - awesome-typescript-loader is archived and not developed anymore: https://github.com/s-panferov/awesome-typescript-loader - we should move off of it.

    warning "workspace-aggregator-8cdbb08c-5596-4d6c-b0cd-64b3ff91330b > @jupyterlab/ui-components > awesome-typescript-loader@5.2.1" has incorrect peer dependency "typescript@^2.7 || ^3".

  • (For another issue...) Why do we have the babel loader as a dev dependency of ui-components, but not webpack? For the tests?

    warning "workspace-aggregator-8cdbb08c-5596-4d6c-b0cd-64b3ff91330b > @jupyterlab/ui-components > babel-loader@8.1.0" has unmet peer dependency "webpack@>=2".

  • See @nteract/transform-vdom latest version is 4.0.16-alpha.0 nteract/outputs#48 - no update available

    warning "workspace-aggregator-8cdbb08c-5596-4d6c-b0cd-64b3ff91330b > @jupyterlab/vdom > @nteract/transform-vdom@4.0.16-alpha.0" has incorrect peer dependency "react@^16.3.2".

  • feat: allow React 17 peer dependency palantir/blueprint#4403 (comment)

    warning "workspace-aggregator-8cdbb08c-5596-4d6c-b0cd-64b3ff91330b > @jupyterlab/ui-components > @blueprintjs/core > react-popper@1.3.7" has incorrect peer dependency "react@0.14.x || ^15.0.0 || ^16.0.0".

  • feat: allow React 17 peer dependency palantir/blueprint#4403 (comment)

    warning "workspace-aggregator-8cdbb08c-5596-4d6c-b0cd-64b3ff91330b > @jupyterlab/ui-components > @blueprintjs/core > react-popper > create-react-context@0.3.0" has incorrect peer dependency "react@^0.14.0 || ^15.0.0 || ^16.0.0".

  • storybook is not yet compatible with webpack 5

    warning "workspace-aggregator-8cdbb08c-5596-4d6c-b0cd-64b3ff91330b > @jupyterlab/ui-components > @storybook/addon-actions > @storybook/api > @reach/router@1.3.4" has incorrect peer dependency "react-dom@15.x || 16.x || 16.4.0-alpha.0911da3".

@jasongrout
Copy link
Contributor

If someone can takeover looking at each of these and either deciding they are not important for 3.0, or if we should do something about them, and updating the comment above, that would help us keep track of what we are doing for 3.0 and what we are leaving on the table for later.

@fcollonval
Copy link
Member

fcollonval commented Nov 28, 2020

Comment: following #9227, it would be good to update to @types/react v17 that was release a week ago (https://www.npmjs.com/package/@types/react/v/17.0.0).

This can be confusing if not updated due to the explicit dependency in @jupyterlab/apputils.

@jtpio
Copy link
Member Author

jtpio commented Nov 30, 2020

Sounds good, thanks @fcollonval.

I was wondering why @types/react is in dependencies and not devDependencies in the first place, but there seems to be some details about this in #4367 and #4386.

@fcollonval
Copy link
Member

I was wondering why @types/react is in dependencies and not devDependencies in the first place, but there seems to be some details about this in #4367 and #4386.

Ja this is still weird for me. Thanks for pointing to the related PR. It may be that with typescript being more mature now the situation is improved and the types could be moved to dev dependencies. But this definitely will require testing.

@jtpio
Copy link
Member Author

jtpio commented Nov 30, 2020

But this definitely will require testing

Yes probably something to reconsider post 3.0. It indeed looks like they could eventually be moved back to devDependencies.

@blink1073
Copy link
Member

Closing as addressed for this release

@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Jun 9, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

No branches or pull requests

4 participants