New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Refactor statusbar #5514
Merged
Merged
[WIP] Refactor statusbar #5514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with the status bar.
ian-r-rose
force-pushed
the
refactor-statusbar
branch
from
October 18, 2018 23:36
8d87385
to
cd634af
Compare
ian-r-rose
force-pushed
the
refactor-statusbar
branch
from
October 19, 2018 01:31
cd634af
to
3ec2fe3
Compare
Still WIP? |
Yeah, I think so. It's an improvement right now, but I still want to hack at it a bit. |
Though I suppose we could merge and iterate, since this would be a painful rebase... |
👍 for iteration |
Okay, merge away then! |
Done, thanks! |
lock
bot
added
the
status:resolved-locked
Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
label
Aug 8, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
pkg:statusbar
status:resolved-locked
Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finishes #5352. This is a big restructuring of the status bar extension to be more idiomatic and in line with the rest of the core codebase.
statusbar
extension into two packages,statusbar
andstatusbar-extension
.IDefaultsManager
. This was mostly redundant with the actualIStatusBar
interface, and I found it pretty confusing. Extension authors should add status items using theIStatusBar
. One downside of this is that theIDefaultsManager
handled some logic about enabling and disabling status items via the settings registry. We may want to revisit that, but at the moment all of the status items are individual plugins, so they can be disabled at the application level.notebook-extension
. Several of the status items that are more cross-cutting in their application remain in thestatusbar-extension
.