New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The statusbar strikes back #5577
Merged
blink1073
merged 13 commits into
jupyterlab:master
from
ian-r-rose:the-statusbar-strikes-back
Nov 3, 2018
Merged
The statusbar strikes back #5577
blink1073
merged 13 commits into
jupyterlab:master
from
ian-r-rose:the-statusbar-strikes-back
Nov 3, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
status items to be the same as their plugin id.
Best PR title ever. |
blink1073
approved these changes
Nov 3, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
lock
bot
added
the
status:resolved-locked
Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
label
Aug 8, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
maintenance
pkg:statusbar
status:resolved-locked
Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finishes #5352.
StatusBar
widget.@jupyterlab/codemirror
, especially the application rendermime. In that instance, CodeMirror is used to provide syntax highlighting for rendered code blocks. We could try to factor that out into an abstracted functionality provided by therendermime-extension
. On the other hand, it makes the application rendermime less useful out-of-the-box, so maybe I am overthinking it.