New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a command to enable the extension manager #6200
Conversation
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
Or maybe the plan for 1.0 is to enable it by default? |
cc: @vidartf @tgeorgeux I think because there isn't yet a story for what to do about extensions that are front-end + back-end, this feature is disabled by default. I don't have a problem with making it easier to discover, but maybe we should add the word "experimental" or something. What do Vidar and Tim think? |
The other reason this was a bit hidden was that we didn't want users to have to install node in order to install lab. So we wanted to hide it a bit until we at least had some feature-detection for node on the frontend. |
Also, there was still some concern about messaging to users that we do not vet these extensions in any way. |
We already have a way to tell if node is available on the client:
I think with that check this PR should go in along with #6277 that solves the companion install piece. |
Agreed that it should still be disabled by default so we can hit the user with that warning dialog. |
@blink1073 the last commit (0b1a40d) checks if the builder is available, and disables the command otherwise: |
So now the current state is as follows:
Should we also add the word "experimental" (or similar) as @afshin suggested? For example: "Enable Extension Manager (experimental)" |
+1. The more caveats the better at this stage, I think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. This looks good to me now!
Congrats on your first merge, @aschlaep! |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related discussion. |
This adds the
Enable Extension Manager
command to the command palette and the main menu.It can sometimes be a bit difficult to figure out how to enable the extension manager.
Having it exposed as a command should make it more accessible and simplify the steps listed in the docs.