Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Vega and Vega-Lite #6294

Merged
merged 1 commit into from May 2, 2019
Merged

Update Vega and Vega-Lite #6294

merged 1 commit into from May 2, 2019

Conversation

domoritz
Copy link
Member

@domoritz domoritz commented May 1, 2019

No description provided.

@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@jasongrout
Copy link
Contributor

Thanks! Any big changes we should be aware of?

@domoritz
Copy link
Member Author

domoritz commented May 1, 2019

There are quite a number of fixes and improvements but this should be a no-brainer.

@blink1073 blink1073 added this to the 1.0 milestone May 2, 2019
blink1073
blink1073 approved these changes May 2, 2019
View reviewed changes
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit fe59e85 into jupyterlab:master May 2, 2019
@domoritz domoritz deleted the update-vg-5 branch May 2, 2019 09:01
@jasongrout jasongrout mentioned this pull request May 8, 2019
Closed
@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Aug 7, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blink1073 blink1073 blink1073 approved these changes

Assignees
No one assigned
Labels
enhancement maintenance pkg:vega status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@domoritz @jasongrout @blink1073