Remove extraneous 'Find and Replace...' item from the edit menu and codemirror #6350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
|
LGTM, thanks! |
lock
bot
added
the
status:resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Fixes #6322
Code changes
This removes the
IFindReplacerinterface and allfindReplacerslogic from the Edit menu. It also removes the Find and Replace command added by the CodeMirror extension. These are being removed in favor of the new interfaces provided by the documentsearch package.User-facing changes
Removes the
Find and Replaceitem from the edit menu in favor of theFindoption which provides replace functionality as well.Backwards-incompatible changes
This removes the
findReplacersproperty from theeditMenu. Extensions that would like to add Find or Find and Replace functionality should use the documentsearch package instead.