Hide the Last Modified column on a narrow filebrowser. #6406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
|
Looks like a lint failure. |
|
Approved by @ian-r-rose above. Tests pass (except an error @ian-r-rose and I decided was unrelated). Thanks! |
|
Thanks @jasongrout! |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related discussion. |
jasongrout
added
the
status:resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Fixes #6093
Code changes
Adds an onResize handler to the directory listing that toggles a class when the width is narrow. Additionally, the last modified column css hides itself when the directory listing is narrow.
User-facing changes
When the user narrows the filebrowser, the last modified column disappears.
Before
Minimal width:
After
Just over 250px:
Just under 250px wide:
Minimum width filebrowser:
Backwards-incompatible changes
None.