New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Audit keyboard shortcuts for Accel instead of Ctrl #6447
Conversation
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
Testing this, I noticed that the redo event was never getting triggered on mac. After testing a lot of things, I realized that on mac/firefox, pressing command, shift, and a key was triggering a keydown event with shiftKey set to false. To test, you can go to a blank page, open the console, and do I also tested firefox on windows, and it correctly reported the shiftKey status (though there command is mapped to the OS modifier on that test page). The end result is that the |
Testing this, I noticed that |
Actually, for a mac, Cmd W is close tab and Cmd Shift W is close window, whereas Q is associated with closing an application or the system (locking or logging out), so from that perspective, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think reverting Accel Shift Q
back to Ctrl Shift Q
, and fixing the small typo Steve pointed out, are all that is needed before a positive review from me.
(and apologies for not catching that Accel Shift Q didn't work on the issue...)
Sounds good. @jasongrout Do think the |
Possibly. We can do that on another issue. I'd love if someone on a mac can confirm too to make sure I'm not crazy (or my browser). |
Thanks! |
Turns out that creating a new firefox profile made things start working for me, and things worked fine on two other macs we were testing, so I think this was just my issue. |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related discussion. |
Fixes #5023. This changes some
Ctrl
shortcuts toAccel
for more consistency with Mac users. I'd appreciate it if a Mac user could test the binder link to see if things seem to be working correctly.application:activate-next-tab
Ctrl Shift ]
application:activate-previous-tab
Ctrl Shift [
editmenu:redo
Ctrl Shift Z
Accel Shift Z
editmenu:undo
Ctrl Z
Accel Z
filemenu:close-and-cleanup
Ctrl Shift Q
Accel Shift Q
helpmenu:toggle
Ctrl Shit H
console:linebreak
Ctrl Enter
Accel Enter
Ctrl Enter
to do something differentnotebook:enter-command-mode
Ctrl M
(??)notebook:run-cell
Ctrl Enter
notebook:split-cell-at-cursor
Ctrl Shift -
References
#5203
#1681
Code changes
closeAndCleaner
menu itemclose
if there is no more specific action to be taken.User-facing changes
"Close and Cleanup" now applies more uniformly to widgets.
Some Mac users will see their shortcuts change to
Cmd
.Backwards-incompatible changes
None.