Change keyboard shortcut for 'Close Tab' to 'Alt+W' from 'Accel+W'. #6486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
|
Looks like unrelated async test failures. I restarted the failed tests. |
|
Thanks again! |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related discussion. |
jasongrout
added
the
status:resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Fixes #6357.
Code changes
This changes the keyboard shortcut for the 'Close Tab' command to 'Alt+W' from 'Accel+W'. On Windows and MacOS 10.14, 'Accel+W' closes the whole browser tab for several browsers. Per the discussion in #6357 , the 'Alt+W' shortcut looks like it is available and will not conflict with any browser shortcuts.
User-facing changes
Before:
After:
Backwards-incompatible changes
None