Added download attribute to Download context menu option #6546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
|
Nice! For reference, see https://developer.mozilla.org/en-US/docs/Web/HTML/Element/a#Attributes How about we set the value as the filename? I think that's how the attribute works. |
|
When the value is left blank, the original filename of the file on the server is taken for that. So it already serve the correct filename. |
|
Awesome, thanks! |
|
This works great, thanks! |
jasongrout
approved these changes
Jun 12, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related discussion. |
jasongrout
added
the
status:resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Code changes
When downloading html-files via the context-menu option, the file just opens in a new browser-tab instead of getting downloaded. To prevent this, we tell the browser explicitly, that we want to download that file.
Added HTML5-download-tag to Download.
User-facing changes
Backwards-incompatible changes