Remove settings table view #6646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes jupyterlab#6642 partially addresses jupyterlab#6623
|
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
|
Nice! Looks good. Thanks! |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related discussion. |
jasongrout
added
the
status:resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Closes #6642
Partially addresses #6623
Code changes
Removes the table settings editor widget and all references to it
User-facing changes
There is no longer a "Table View" of the settings. The tab to switch between the table and raw view has been removed and the plugin list takes its space.
Backwards-incompatible changes
The settings editor widget API has changed to remove tracking whether the user has selected the raw or table view