Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust settings toolbar alignment #6654

Merged
merged 1 commit into from Jun 20, 2019

Conversation

jasongrout
Copy link
Contributor

References

Fixes #6622

Code changes

User-facing changes

Adjusts the alignment of toolbar items in the settings editor.

before:
Screen Shot 2019-06-19 at 4 14 26 PM

after:
Screen Shot 2019-06-19 at 4 11 26 PM

Backwards-incompatible changes

@jasongrout jasongrout added this to the 1.0 milestone Jun 19, 2019
@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

Copy link
Contributor

@ellisonbg ellisonbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ellisonbg ellisonbg merged commit f81ece9 into jupyterlab:master Jun 20, 2019
@lock
Copy link

lock bot commented Aug 6, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related discussion.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 6, 2019
@jasongrout jasongrout added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Aug 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:Settings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vertical alignment of text in settings editor
2 participants