Added debug messages #6704
Merged
Added debug messages #6704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
|
This looks good to me, modulo the docstrings about API stability @jasongrout raised. Is using a |
…ot part of the public api
I think |
jasongrout
approved these changes
Jul 31, 2019
There was a problem hiding this comment.
I've added docstrings everywhere warning that these things are experimental.
Can someone review my docstrings? @SylvainCorlay, @afshin, @JohanMabille, etc.?
|
This looks good to me! |
|
@afshin - feel free to merge if it also looks good to you. I'll merge tomorrow morning (~8 hours) if you haven't and there are no objections. |
SylvainCorlay
approved these changes
Jul 31, 2019
|
Sweet, thank you! |
|
🎉 |
|
Awesome! |
lock
bot
added
the
status:resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
This PR partially implements changes described in jupyter/jupyter_client#446.
It completes #6544 and allows to send debug_request messages on the Control channel.
This PR should not be merged until the Jupyter Kernel Protocol has been updated as described in jupyter/jupyter_client#446.
Code changes
requestDebug)User-facing changes
None
Backwards-incompatible changes
None