Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up the Clean Logic #6734

Closed
blink1073 opened this issue Jun 29, 2019 · 1 comment
Closed

Clean up the Clean Logic #6734

blink1073 opened this issue Jun 29, 2019 · 1 comment
Assignees
Labels
enhancement status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:Build System
Milestone

Comments

@blink1073
Copy link
Member

We need to improve the logic around cleaning. We should follow the lead of git clean and support flags for the jupyter lab clean command here.

The current logic only cleans the staging directory:

for name in ['staging']:
in the app directory.

I think we should add flags for cleaning:

  • The static directory
  • The settings directory (for recovery - warn if there are local linked extensions)
  • The extensions directory (for recovery)
  • The entire app directory (for recovery)
@blink1073
Copy link
Member Author

@telamonian, do you want to take on this one?

@blink1073 blink1073 modified the milestones: 1.1, 1.2 Aug 27, 2019
@jasongrout jasongrout modified the milestones: 1.2, 2.0 Oct 11, 2019
@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Jan 4, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:Build System
Projects
None yet
Development

No branches or pull requests

3 participants