New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove focus on esc in console #6822
Conversation
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
I would like a little help with this PR. I have been able to remove focus from the input (though this requires a small hack), but the keyboard shortcuts (e.g., 0,0) are not correctly handled. Does anyone know what needs to be done for this? |
@ciyer You are right, this is a stubborn one! I have had a bit of a hard time as well wresting control from CodeMirror here. I'll play around a bit more this weekend to see if I can figure out what is going on... |
@ian-r-rose Appreciate it, thanks! |
Hi @ciyer, okay, I think I have figured it out -- in addition to calling |
Nice work! That makes sense. I’m on vacation and don’t have a computer with me ATM, but I can fix the code next week, when I’m back. Or you can submit your fix, and I will close my PR - whichever you prefer. |
Happy to wait for you to finish it off, @ciyer |
1bb0fd9
to
bc6d7bc
Compare
@ian-r-rose Thanks to your help, I've been able to make fix for this issue! |
Looks good, thanks @ciyer! |
References
Code changes
Remove focus from the console input on 'Esc' (27).
User-facing changes
The 'Esc' in the input cell of the console removes focus and switches to command mode.
Backwards-incompatible changes
None.