New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix for contextual help layout #6933
Conversation
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
Thanks for finding the issue, filing the issue, tracking down the fix, and submitting a PR! |
CC @afshin as well |
Ah, I figured out why display:flex was there. The default content depends on it to center the content vertically: jupyterlab/packages/inspector/style/base.css Lines 49 to 55 in 52a3305
I think it's probably even better to not center vertically? Then people looking at the top of the tab for content don't miss the function. But we probably should go ahead and delete the relevant items in the default-content css (or just add back in the display:flex there) |
Could you put in one more PR to add |
opened #6935 ! |
oh wait my bad I confused the classes, I will change the commit on the PR there |
Thanks! |
@meeseeksdev backport to 1.0.x |
…3-on-1.0.x Backport PR #6933 on branch 1.0.x (fix for contextual help layout)
References
fix for #6928
rationale is on the issue.