New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix comm_info_request content to conform to spec in a backwards-compatible way #6949
Conversation
…tible way. This workaround should be removed in services 5.0. Fixes jupyterlab#6947
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
@meeseeksbot, backport to 1.0.x |
@meeseeksdev, backport to 1.0.x |
@meeseeksdev hello |
Look at me, @blink1073, I'm Mr. Meeseeks! |
@meeseeksdev backport to 1.0.x |
@blink1073, when do you expect to release a 1.0.x version with this patch? |
We can try to do one today. We'd be testing out a new system for releasing patch branches, so there might be delays, though. |
@jasongrout, happy to block out a time this afternoon to meet up. |
…n a backwards-compatible way
…9-on-1.0.x Backport PR #6949 on branch 1.0.x (Fix comm_info_request content to conform to spec in a backwards-compatible way)
jlab 1.0.5 is out now on pypi with this bugfix. |
Thanks @jasongrout! 🎉 |
References
Fixes #6947
Code changes
Adds the comm info
target_name
content attribute, and a workaround makingtarget_name
be set from the incorrecttarget
if it makes sense.This workaround should be removed in services 5.0.
User-facing changes
Backwards-incompatible changes
None. It does deprecate the
target
attribute, to be removed in services 5 (jlab 2).