Fix Vega downloads and download URLs in general #7022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
Before, we would get URLs like http://example.com/files/file.txt/?_xsrf=token, and now the slash after file.txt is eliminated.
…rver. Perhaps we should also use the services package to actually send the request to the server. That would complicate these plugins beyond simple rendermime plugins, though. Fixes jupyterlab#7017
jasongrout
force-pushed
the
vega-download-path
branch
from
180ce43
to
70ac6fa
Compare
|
CC @domoritz for a sanity check on how we are overriding the vega sanitizer. |
|
This should be backported to 1.0.x once it is merged. |
jasongrout
changed the title
This was referenced Aug 15, 2019
domoritz
approved these changes
Aug 16, 2019
You clicked on the "launch binder" link above? |
|
Yes |
I'm seeing the same thing. Someone on another issue said that Binder is having issues right now. |
|
LGTM, thanks! |
|
@meeseeksdev backport to 1.0.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/jupyterlab
that referenced
this pull request
Aug 16, 2019
blink1073
added a commit
that referenced
this pull request
Aug 16, 2019
…2-on-1.0.x Backport PR #7022 on branch 1.0.x (Fix Vega downloads and download URLs in general)
This was referenced Aug 19, 2019
lock
bot
added
the
status:resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Fixes #7017
See also vega/altair#1651
Code changes
Two main things:
User-facing changes
Vega plots with json transforms now work.
Backwards-incompatible changes
None.