From 5b61a77729a75a2f63e21e5384012a3fc9312ac5 Mon Sep 17 00:00:00 2001 From: telamonian Date: Fri, 16 Aug 2019 02:07:31 -0400 Subject: [PATCH] restores silent failure behavior when a fileType has no iconClass --- packages/ui-components/src/icon/iconregistry.tsx | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/packages/ui-components/src/icon/iconregistry.tsx b/packages/ui-components/src/icon/iconregistry.tsx index d2a5d70b6bfe..13213660c7f5 100644 --- a/packages/ui-components/src/icon/iconregistry.tsx +++ b/packages/ui-components/src/icon/iconregistry.tsx @@ -125,12 +125,16 @@ export class IconRegistry implements IIconRegistry { resolveName(name: string): string { if (!(name in this._svg)) { - // assume name is really a className, split the className into parts and check each part - for (let className of name.split(/\s+/)) { - if (className in this._classNameToName) { - return this._classNameToName[className]; + // skip resolution if name is not defined + if (name) { + // assume name is really a className, split the className into parts and check each part + for (let className of name.split(/\s+/)) { + if (className in this._classNameToName) { + return this._classNameToName[className]; + } } } + if (this._debug) { // couldn't resolve name, mark as bad and warn console.error(`Invalid icon name: ${name}`);