From 0893e7b8ab507e75c306cb52cb4479ab93db5bde Mon Sep 17 00:00:00 2001 From: Malcolm Ramsay Date: Mon, 19 Aug 2019 14:24:44 +1000 Subject: [PATCH] Fix baseURL in vega extensions #7047 This ensures that the path of the current notebook is included in the URL for data files in the vega extensions. --- packages/vega4-extension/src/index.ts | 3 +++ packages/vega5-extension/src/index.ts | 3 +++ 2 files changed, 6 insertions(+) diff --git a/packages/vega4-extension/src/index.ts b/packages/vega4-extension/src/index.ts index e66903e13605..2332e013107d 100644 --- a/packages/vega4-extension/src/index.ts +++ b/packages/vega4-extension/src/index.ts @@ -92,7 +92,10 @@ export class RenderedVega extends Widget implements IRenderMime.IRenderer { this._result.view.finalize(); } + const path = await this._resolver.resolveUrl(''); + const baseURL = await this._resolver.getDownloadUrl(path); const loader = vega.vega.loader({ + baseURL, http: { credentials: 'same-origin' } }); diff --git a/packages/vega5-extension/src/index.ts b/packages/vega5-extension/src/index.ts index e728c3f22c58..8013bac7d54b 100644 --- a/packages/vega5-extension/src/index.ts +++ b/packages/vega5-extension/src/index.ts @@ -92,7 +92,10 @@ export class RenderedVega extends Widget implements IRenderMime.IRenderer { this._result.view.finalize(); } + const path = await this._resolver.resolveUrl(''); + const baseURL = await this._resolver.getDownloadUrl(path); const loader = vega.vega.loader({ + baseURL, http: { credentials: 'same-origin' } }); const sanitize = async (uri: string, options: any) => {