Require jinja2 2.10+ to fix extra escaping

[blink1073]

References

Fixes #7053.

Code changes

Adds a requirement on jinja2 2.10+ to pick up pallets/jinja#718

User-facing changes

Fixes inability to load JupyterLab due to ill-formatted page config.

Backwards-incompatible changes

None

[jupyterlab-dev-mode]

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link:

[jasongrout]

Fixes #6941.

That was reported with jlab 1.0.4, so I think that may be a separate issue.

[blink1073]

Thanks, I just updated the top level description.

[blink1073]

Note to self: conda-forge recipe will need an update as well.

[jasongrout]

And jupyterlab_server, since it uses the same tojson filter.

[blink1073]

PR coming...

[blink1073]

jupyterlab/jupyterlab_server#77

[jasongrout]

Add missing whatwg-fetch dependency

Huh. Why did this not complain before? This PR should not have changed this requirement, I think?

[blink1073]

Other recent PRs were failing for the same reason. I think it may have come in transitively before.

[blink1073]

Still failing. whatwg-fetch itself hasn't been updated in over a year.

[blink1073]

webpack-cli was updated 3 days ago...

[jasongrout]

% yarn why whatwg-fetch                                                                 outputconsole
yarn why v1.15.2
[1/4] 🤔  Why do we have the module "whatwg-fetch"...?
[2/4] 🚚  Initialising dependency graph...
[3/4] 🔍  Finding dependency...
[4/4] 🚡  Calculating file sizes...
=> Found "whatwg-fetch@3.0.0"
info Has been hoisted to "whatwg-fetch"
info Reasons this module exists
   - "workspace-aggregator-3bc6e7ea-abd1-4618-aaa4-5dc09a06097c" depends on it
   - Hoisted from "_project_#@jupyterlab#example-app#whatwg-fetch"
   - Hoisted from "_project_#@jupyterlab#example-notebook#whatwg-fetch"
   - Hoisted from "_project_#@jupyterlab#example-terminal#whatwg-fetch"
   - Hoisted from "_project_#@jupyterlab#example-cell#whatwg-fetch"
   - Hoisted from "_project_#@jupyterlab#example-filebrowser#whatwg-fetch"
   - Hoisted from "_project_#@jupyterlab#example-console#whatwg-fetch"
   - Hoisted from "_project_#fbjs#isomorphic-fetch#whatwg-fetch"
info Disk size without dependencies: "64KB"
info Disk size with unique dependencies: "64KB"
info Disk size with transitive dependencies: "64KB"
info Number of shared dependencies: 0
=> Found "webpack-visualizer-plugin#whatwg-fetch@0.9.0"
info Reasons this module exists
   - "_project_#@jupyterlab#application-top#webpack-visualizer-plugin#react#fbjs" depends on it
   - Hoisted from "_project_#@jupyterlab#application-top#webpack-visualizer-plugin#react#fbjs#whatwg-fetch"
info Disk size without dependencies: "24KB"
info Disk size with unique dependencies: "24KB"
info Disk size with transitive dependencies: "24KB"
info Number of shared dependencies: 0
✨  Done in 1.58s.

[jasongrout]

The webpack visualizer is new, right? It seems to be getting a very old version of the library, 0.9.0, from about 4 years ago.

[blink1073]

Add a new resolution 😄?

[blink1073]

Actually, webpack visualizer is unmaintained, we should be using https://github.com/webpack-contrib/webpack-bundle-analyzer.

[jasongrout]

The webpack visualizer is new, right?

It was recently re-enabled: #6706

[blink1073]

@vidartf, the failing test is test_build_custom_minimal_core_config. Do you mind taking a look at this one?

[vidartf]

@blink1073 The coreconfig test uses the package.json in staging. Should the changes in dev_mode/package.json be propagated? How does the other test builds know to use the dev mode package.json ?

[blink1073]

Aha! The whatwg-fetch requirement must come from one of the requirements that wasn't included in the minimal test.

[blink1073]

Python tests are passing now, thanks @vidartf!

[blink1073]

@jasongrout, it is getting to be the end of my time at the keyboard for today. I can cut a patch release first thing tomorrow.

[jasongrout]

Sounds good. I'm afk myself.

[blink1073]

@meeseeksdev backport to 1.0.x

[lumberbot-app]

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

1. Checkout backport branch and update it.

$ git checkout 1.0.x
$ git pull

2. Cherry pick the first parent branch of the this PR on top of the older branch:

$ git cherry-pick -m1 4b2cf55c184643950d270c359e8acb208bccdd15

3. You will likely have some merge/cherry-pick conflict here, fix them and commit:

$ git commit -am 'Backport PR #7055: Require jinja2 2.10+ to fix extra escaping'

4. Push to a named branch :

git push YOURFORK 1.0.x:auto-backport-of-pr-7055-on-1.0.x

5. Create a PR against branch 1.0.x, I would have named this PR:

"Backport PR #7055 on branch 1.0.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

[blink1073]

I manually made the jinja2 dependency change and released 1.0.7.