Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of page config for non-strings #7061

Merged
merged 1 commit into from Aug 21, 2019

Conversation

blink1073
Copy link
Member

@blink1073 blink1073 commented Aug 21, 2019

References

Fixes #6858. Fixes #7058

Code changes

Fixes our handling of page config for non-string objects.

User-facing changes

Un-breaks the application.

Backwards-incompatible changes

@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

Copy link
Member

@afshin afshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

FYI for anyone coming to this issue: this is an API we expect to change for 2.0

@blink1073 blink1073 merged commit e7df370 into jupyterlab:master Aug 21, 2019
@blink1073
Copy link
Member Author

@meeseeksdev backport to 1.0.x

meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this pull request Aug 21, 2019
blink1073 added a commit that referenced this pull request Aug 21, 2019
…1-on-1.0.x

Backport PR #7061 on branch 1.0.x (Fix handling of page config for non-strings)
@jasongrout jasongrout modified the milestones: 1.0.x, 1.1 Aug 23, 2019
@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Sep 22, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Sep 22, 2019
@blink1073 blink1073 deleted the fix-pageconfig branch March 29, 2020 09:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:Build System
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't disable jupyterlab extension jupyterlab wont launch - blank screen since 1.0
3 participants