Handling error during selecting a kernel #7094
Conversation
|
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
| @@ -623,7 +623,11 @@ export class ClientSession implements IClientSession { | |||
| }); | |||
| } | |||
| if (model) { | |||
| return this._changeKernel(model).then(() => undefined); | |||
| return this._changeKernel(model).then(() => undefined) | |||
There was a problem hiding this comment.
_changeKernel devolves down to two cases:
In the above case, no error message is shown, and presumably is the case you are hitting, and
In the above case, the error message is shown if there is a problem.
If we trap errors from _changeKernel, we end up showing the error twice if we hit the second case above. How about we change _changeKernel to also show an error in the first case above instead?
There was a problem hiding this comment.
@jasongrout Nice catch. I have made the required changes. Do let me know your comments.
|
Thanks! I've put in a few comments inline. |
|
Thanks and congratulations on your first contribution @IMAM9AIS! |
|
Hi @jasongrout , Thanks a lot for this merge. We are currently using 0.33.x version of jupyter lab in our internal systems, while this PR was merged into the master.We wanted to understand what steps will be needed if we wanted to backport this fix in 0.33.x version. Do let me know. |
lock
bot
added
the
status:resolved-locked
This PR tries to solve the issue created here:- #7093