Fix file browser location in tree view. #7155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
|
@afshin any remarks on that? |
afshin
changed the title
afshin
approved these changes
Sep 26, 2019
There was a problem hiding this comment.
I am 👍 on this. I submitted a small pull request https://github.com/dmarth/jupyterlab/pull/1 against your branch to add some clarifying comments.
|
@meeseeksdev backport to 1.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/jupyterlab
that referenced
this pull request
Oct 10, 2019
jasongrout
added a commit
that referenced
this pull request
Oct 10, 2019
…5-on-1.x Backport PR #7155 on branch 1.x (Fix file browser location in tree view.)
lock
bot
added
the
status:resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
#6874
Code changes
The file browser now opens the
/treepath first, then optionally thefile-browser-pathis shown. Additionally, the query parameter is deleted from the URL.User-facing changes
The query parameter is now removed from the URL.