Allow different mimetypes for the clipboard data

[Madhu94]

This should allow multiple mime types on the clipboard, for #7119

Let me know your thoughts on this.

[jupyterlab-dev-mode]

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link:

[blink1073]

Thanks!

[Madhu94]

Thoughts on using the new Async Clipboard API and falling back to the current implementation on Safari ? (mdn's compat table says clipboard API support is unknown for Safari)

[blink1073]

In this case I don't think the capability is worth the added complexity of two code paths.

[Madhu94]

Yes that's true. I just wanted to use that one because it errors better and isn't synchronous.

…

On Fri, 13 Sep 2019, 16:17 Steven Silvester, ***@***.***> wrote: In this case I don't think the capability is worth the added complexity of two code paths. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#7202?email_source=notifications&email_token=ACEZEDEUOVDR4T2JWQN7OWLQJNVUJA5CNFSM4IWKUP7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6UVJ7Q#issuecomment-531191038>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACEZEDAII7TNEX2WZZROZO3QJNVUJANCNFSM4IWKUP7A> .

[blink1073]

Ah, I missed that it had better error handling. Go for it! Sent from Phone

________________________________ From: Madhu94 <notifications@github.com> Sent: Friday, September 13, 2019 6:59 AM To: jupyterlab/jupyterlab Cc: Steven Silvester; Comment Subject: Re: [jupyterlab/jupyterlab] Allow different mimetypes for the clipboard data (#7202) Yes that's true. I just wanted to use that one because it errors better and isn't synchronous.

On Fri, 13 Sep 2019, 16:17 Steven Silvester, ***@***.***> wrote: In this case I don't think the capability is worth the added complexity of two code paths. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#7202?email_source=notifications&email_token=ACEZEDEUOVDR4T2JWQN7OWLQJNVUJA5CNFSM4IWKUP7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6UVJ7Q#issuecomment-531191038>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACEZEDAII7TNEX2WZZROZO3QJNVUJANCNFSM4IWKUP7A> .

— You are receiving this because you commented. Reply to this email directly, view it on GitHub<#7202?email_source=notifications&email_token=AAP735A4T6Z4VS3I4D7TJFDQJN6DBA5CNFSM4IWKUP7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6UZZLQ#issuecomment-531209390>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AAP735D4P26YX4VTJM7LK4DQJN6DBANCNFSM4IWKUP7A>.

[Madhu94]

I tried out the async API - the error messages were really great (in the old way, you never know why document.execCommand would fail) and there is not need to write the data you want to copy to the DOM first before invoking this API.

But I also faced problems -

• It does not allow any mime type other than text/plain or image/png. It errored when I tried text/html
• It is better to use it with the Permissions API, which is good, but the required "clipboard-write" permission doesn't seem to be supported supported in Firefox.
• TS typings may not have caught up yet ? ( ClipboardItem name is unknown) So I made a global.d.ts to work around for the moment.
• As mentioned above, Safari support doesn't seem to be implemented yet (I haven't verified behavior on Safari yet).

Maybe we can wait for the API to improve a bit?

[Madhu94]

Some references - original proposal and recent status update

[blink1073]

Waiting sounds good to me, so this is ready to merge?

[Madhu94]

Yeah, ready for review/merge

[blink1073]

Thanks!

[jasongrout]

@meeseeksdev backport to 1.x