Fix overwriting of target attribute of anchors rendered by IPython.display #7215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
kavishdahekar
changed the title
kavishdahekar
changed the title
blink1073
approved these changes
Sep 16, 2019
|
Thanks again @kavishdahekar, and congratulations on your first JupyterLab PR! |
|
Thanks @blink1073 :) Looking forward to contributing more to the project. |
|
@meeseeksdev backport to 1.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/jupyterlab
that referenced
this pull request
Sep 18, 2019
…nchors rendered by IPython.display
jasongrout
added a commit
that referenced
this pull request
Sep 18, 2019
…5-on-1.x Backport PR #7215 on branch 1.x (Fix overwriting of target attribute of anchors rendered by IPython.display)
lock
bot
added
the
status:resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix for issue where user provided value for target attribute of anchor tags rendered by IPython.display were overwritten by '_blank' or '_self'.
References
Fixes #6827
Code changes
The bugfix will overwrite the
targetattribute only if it was not set.Setting of the
relattribute tonoopenermoved to separate if block.User-facing changes
Users rendering anchor elements using IPython.display will be able to set custom values for "target" attribute.
Backwards-incompatible changes