Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add kernelspec metadata #7229

Merged
merged 3 commits into from Sep 18, 2019
Merged

Add kernelspec metadata #7229

merged 3 commits into from Sep 18, 2019

Conversation

declanvk
Copy link
Contributor

References

This closes #7228 based on the proposed actions.

Code changes

Added metadata field to ISpecModel and validation code. Added env field to validation code.

User-facing changes

This enables extension developers to coordinate easily with a back-end application that store information in the kernelspec metadata.

Backwards-incompatible changes

None

@dleen @blink1073

@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@declanvk declanvk changed the title Kernelspec metadata Add kernelspec metadata Sep 18, 2019
dleen
dleen approved these changes Sep 18, 2019
View reviewed changes
Copy link

@dleen dleen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

blink1073
blink1073 approved these changes Sep 18, 2019
View reviewed changes
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@blink1073 blink1073 added this to the 1.2 milestone Sep 18, 2019
@blink1073 blink1073 merged commit c400c92 into jupyterlab:master Sep 18, 2019
@declanvk declanvk deleted the kernelspec-metadata branch September 18, 2019 20:05
@jasongrout
Copy link
Contributor

@meeseeksdev backport to 1.x

meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this pull request Sep 18, 2019
@blink1073
Backport PR jupyterlab#7229: Add kernelspec metadata
99f2c3b
@meeseeksmachine meeseeksmachine mentioned this pull request Sep 18, 2019
Merged
jasongrout added a commit that referenced this pull request Sep 18, 2019
@jasongrout
Merge pull request #7234 from meeseeksmachine/auto-backport-of-pr-722…
65619c4 
…9-on-1.x

Backport PR #7229 on branch 1.x (Add kernelspec metadata)
@jasongrout jasongrout modified the milestones: 1.2, 2.0 Oct 11, 2019
@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Nov 10, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Nov 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dleen dleen dleen approved these changes

@blink1073 blink1073 blink1073 approved these changes

Assignees
No one assigned
Labels
enhancement pkg:services status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

Missing metadata from kernelspec model
4 participants
@declanvk @jasongrout @dleen @blink1073