New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes context menu hit test to deal with svg nodes. #7242
Conversation
CC @telamonian |
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
@telamonian - can you review this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
We may want to revisit the decision to ignore Everything else looks good. I added a fix for the icon styling. The sidebar tab icons should now look the same on the right as they do on the left. |
FYI, the tests failure is an unrelated issue (apparently NASA changed its API webpage, breaking a link in our docs). I've emailed NASA about it. |
@jasongrout I noticed about NASA. Leaving that aside, I think the PR is good to go. Mind if I merge it in? |
@telamonian - are your changes also safe to backport to 1.2 and 1.1.x? |
@telamonian - your changes look good to me. Feel free to merge if you think this is backwards compatible to 1.1.x. |
@meeseeksdev backport to 1.x |
what do you know, the backport call actually worked |
…2-on-1.x Backport PR #7242 on branch 1.x (Fixes context menu hit test to deal with svg nodes.)
References
Fixes #7224
Code changes
The context menu hit test now works for any node, not just html elements, though we only run the user-supplied function on html elements for backwards compatibility.
User-facing changes
The Switch Sidebar context menu item should work now.
As well, this PR includes a fix for the styling of the right sidebar icons: previously, they were being rendered upside down.
Backwards-incompatible changes
None. This should be safe to backport to 1.2 and 1.1.x.