New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Celltags in core #7407
Celltags in core #7407
Conversation
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
I think this is a great idea! I'd love to have tags work "out of the box" for jupyter book users. Is it a copy-over from the celltags repo, or a re-implementation? |
@choldgraf this is a reimplementation. I'll let @markellekelly provide more details. She and @isabela-pf did some user testing on the old jupyterlab/jupyterlab-celltags and found the old UI needed some simplifying. While exploring a new UI/UX, @markellekelly also took this opportunity to simplify the extension's code/logic. I think this refactoring will help with future maintenance :) |
I am all for a re-implementation :-) I had a few suggestions, these are now here: #7449 here's a good place to iterate on issues / feedback / etc if this gets into core? The jupyterlab/jupyterlab repo? |
FYI: That is only if you've selected the tags cell headers.
This will be the place for working on this (monorepo, yay). You seem to indicate your feature requests should happen after this PR, which I wholeheartedly agree with. 馃憤 |
PS: Doing a quick scan of the code, it generally looks nice an clean 馃憤 One task that should ideally be done before merging is to add docstrings to all the public (and protected?) methods and functions. |
Kudos on adding dark mode styling. However, c6621b5 does not represent the right approach to dark mode theming, for the icons or otherwise. The commit should be reverted. In jlab core, icons need to be added such that they show up in the DOM as svg nodes, not as CSS background images. This allows us to use CSS variables to directly change the styling of an icon along with the theme. Here's how you do that:
Assuming everything is set up correctly, your icons will get loaded in as |
For general non-icon light mode/dark mode styling, importing/requiring the theme manager is also the wrong approach. Instead, you can just prefix the selector of any light mode specific CSS with [data-jp-theme-light='true'] and prefix the selector of any dark mode specific CSS with [data-jp-theme-light='false'] Here's an existing example of this in jlab core: jupyterlab/packages/rendermime/style/base.css Lines 420 to 426 in 172e664
|
@telamonian thanks!! should be fixed now |
Note: due to onActiveCellMetadataChanged not detecting changes within the 'tags' list (only changes in whether it exists), the separate celltags extension and in-panel cell metadata editor do not always update to reflect changes in tags immediately. |
Tested out this extension today. I'm seeing a couple issues:
|
Just kidding, I was being dumb 馃槅 |
Thanks for making those changes, @markellekelly. A couple of new issues 馃槅
|
@Zsailer I changed the "+" button to serve as an alternative to hitting Enter. Separating tags by spaces and commas is currently the intended behavior, but I can change this if people find it confusing or inconvenient. |
Great, thanks @markellekelly. I'll work with @telamonian to review this in the coming days. Thanks for all your hard work! |
Co-Authored-By: Saul Shanabrook <s.shanabrook@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much @markellekelly!
Yessss this is very exciting! |
@markellekelly Nice work! |
Adds celltags to core JupyterLab. 馃帀
References
Addresses #6952 and jupyterlab/jupyterlab-celltags#179.
Code changes
Creates celltags and celltags-extension packages.
User-facing changes
Adds cell tag area to the notebook tools panel.
Users can:
Backwards-incompatible changes
None
Pinging @vidartf, @telamonian, @choldgraf, @isabela-pf for review and testing.