Make sure label is linked to a control when checking for element type #7458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
jasongrout
reviewed
Nov 2, 2019
packages/apputils/src/toolbar.tsx
Outdated
| // that is linked with `for` attribute, so let it be. | ||
| if ( | ||
| event.target instanceof HTMLLabelElement && | ||
| this.node.querySelector(`#${event.target.getAttribute('for')}`) |
There was a problem hiding this comment.
Can we add && event.target.getAttribute('for') to check if it is undefined?
lock
bot
added
the
status:resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an enhancement to a669392 making sure the label is actually linked to another control.