New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to TypeScript 3.7 #7522
Conversation
Typscript 3.7 throws some errors when compiling Vega-lite 2 and 3, so we turn off lib checks. This was investigated much more deeply in jupyterlab#7428, where we deleted the vega 4 extension and upgraded the vega 5 extension to vega-lite 4.0b11. The vega-lite upgrade was not going smoothly, so we moved it to a separate issue and redid the Typescript upgrade by just using the skipLibCheck flag.
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
There is a newer version of typedoc that supports TS3.7: TypeStrong/typedoc#1129 |
Oh wow, that has to be a record for typedoc supporting a new release! Nice! |
This does not build coreutils docs because it complains about the .json file that is imported. This is probably a typescript or a typedoc bug.
The doc build seems to work, except for coreutils:
Not sure what is going on here. For now, I'm skipping building docs for coreutils. |
Also with this config, it seems that one package's docs don't link to other packages (for example if they import and use definitions from another package, I would love if their docs would link to the definitions in the other package). I'm not sure if this is a change, or if it's broken in our current docs anyway. |
For some reason, typescript itself works fine, but typedoc has this error: File ‘[snip]/jupyterlab/packages/coreutils/src/plugin-schema.json' is not listed within the file list of project ''. Projects must list all files or use an 'include' pattern. This avoids this issue somehow by setting composite to false for typedoc doc builds.
Looks like this is also a problem in the current docs, so no change here on that. |
I figured out a way around the problem. It looks like it is a bug upstream in either typedoc or typescript, dealing with the composite build flag and specifying json files to be included as modules. |
Okay, @blink1073 - ready for review again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I kicked the flaky usage test.
References
This supersedes #7428.
Code changes
Upgrade to Typescript 3.7, and use skipLibChecks on the vega extensions (see #7428 for more details).
User-facing changes
None
Backwards-incompatible changes
Upgraded Typescript